refactor: remove extra if block, use b instead of base in math/base/special/floorsd
#2632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
reviewed
Jul 20, 2024
kgryte
reviewed
Jul 20, 2024
Signed-off-by: Athan <[email protected]>
kgryte
approved these changes
Jul 20, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @gunjjoshi!
Only change I made was to make explicit the type conversions when calling into APIs expecting double-precision floating-point numbers.
gunjjoshi
added a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2632 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
ifblock, and checks the conditions forbin the initialifblock itself, as the return value in both of them is the same, in thejavascriptimplementation.basevariable inCimplementation, we can directly useb.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers